feat(eval): configurable trials, parallelism, and CI threshold support#122
Merged
feat(eval): configurable trials, parallelism, and CI threshold support#122
Conversation
…pport
Extends the eval system to run multiple trials per case with bounded
concurrency and deterministic pass-rate aggregation. Adds --trials,
--ci, and --threshold CLI flags; trial artifacts are written under
{run_dir}/{case_id}/trial-N/ with aggregated.json summaries. Existing
single-trial configs continue working without change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trials_per_case,parallel, andpass_thresholdfields toEvalConfigToml/EvalConfigwith backward-compatible defaults (trials=1,threshold=1.0)TrialResultandCaseTrialsResulttypes; trial artifacts written to{run_dir}/{case_id}/trial-N/withaggregated.jsonper caseEvalRunnertrait withrun_case_trials()backed byJoinSet+Semaphorebounded concurrency--trials,--ci, and--thresholdCLI flags toeval run;--cigates exit code on suite pass rate vs thresholdtrials × cases >= 100Test plan
cargo nextest run -E 'test(eval)')test_eval_run_trials_threshold_and_ci_exit_semantics— verifies 3/5 pass at threshold=0.6 succeeds; 3/5 at threshold=1.0 failstest_eval_run_parallelism_reduces_wall_time— 4 trials × 0.5s sleep complete in <1.6s withparallel=4eval_run_helpupdated to include--trials,--ci,--threshold